Skip to content

test: rename cloud_only marker as access_tokens#32

Merged
quettabit merged 1 commit intomainfrom
qb/upd-test-markers
Apr 14, 2026
Merged

test: rename cloud_only marker as access_tokens#32
quettabit merged 1 commit intomainfrom
qb/upd-test-markers

Conversation

@quettabit
Copy link
Copy Markdown
Member

No description provided.

@quettabit quettabit requested a review from a team as a code owner April 14, 2026 00:29
@quettabit quettabit changed the title test: rename cloud_only test marker as access_tokens test: rename cloud_only marker as access_tokens Apr 14, 2026
@greptile-apps
Copy link
Copy Markdown

greptile-apps bot commented Apr 14, 2026

Greptile Summary

This PR renames the cloud_only pytest marker to access_tokens, reflecting a more precise semantic: the marker now specifically identifies access-token-related tests rather than broadly "cloud-only" tests. As a side effect, test_get_basin_config loses its marker entirely and will now run in the s2-lite integration test suite, which appears intentional since that test doesn't involve access tokens and is presumably supported on s2-lite.

Confidence Score: 5/5

Safe to merge — pure marker rename with intentional, low-risk behavioural change for one test.

All findings are P2 or lower. The rename is consistent across pytest.ini, the CI workflow, and all test annotations. The removal of the marker from test_get_basin_config appears deliberate and correct.

No files require special attention.

Important Files Changed

Filename Overview
pytest.ini Renames the cloud_only marker definition to access_tokens with an updated description; clean and accurate.
.github/workflows/ci.yml Updates the s2-lite integration test filter from not cloud_only to not access_tokens; the s2-cloud job already runs all account-marked tests so access-token tests remain covered there.
tests/test_account_ops.py Replaces @pytest.mark.cloud_only with @pytest.mark.access_tokens on all access-token tests; test_get_basin_config intentionally loses its marker, enabling it to run on s2-lite.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[pytest test run] --> B{Marker filter}
    B --> C["local-checks\nnot (account or basin or stream or metrics)"]
    B --> D["s2-cloud integration\naccount or basin or stream or metrics"]
    B --> E["s2-lite integration\n(account or basin or stream) and not access_tokens"]

    C --> F[Unit tests only]
    D --> G[All account/basin/stream/metrics tests\nincl. access_tokens tests]
    E --> H[Account/basin/stream tests\nexcl. access_tokens tests]

    style G fill:#d4edda
    style H fill:#fff3cd
Loading

Reviews (1): Last reviewed commit: "initial commit" | Re-trigger Greptile

@quettabit quettabit force-pushed the qb/upd-test-markers branch from 122b20f to 3a036a8 Compare April 14, 2026 00:54
@quettabit quettabit merged commit e998b33 into main Apr 14, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant